revset: do not lookup unimported tags or remote branches by unqualified name #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed name Since e7e4952 "git: ensure that remote branches never diverge", the last known "refs/remotes" ref should be synced with the corresponding remote branch. So we can always trust the branch@remote expression. We don't need "refs/tags" lookup either since tags should have been imported by git::import_refs(). FWIW, I'm thinking of reorganizing view.git_refs() map as per-remote views. It would be nice if we can get rid of revsets and template keywords exposing low-level Git ref primitives.
martinvonz
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md